From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 02 Sep 2025 08:50:12 GMT
Subject: Re: [PATCH v2 06/16] odb: move kept cache into `struct packfile_store`
Message-ID: <aLavvRW6A1bWP__1@pks.im>
In-Reply-To: <aK0R38bfUSzbnlb5@nand.local>

On Mon, Aug 25, 2025 at 09:46:07PM -0400, Taylor Blau wrote:
> On Thu, Aug 21, 2025 at 09:39:04AM +0200, Patrick Steinhardt wrote:
> > diff --git a/packfile.h b/packfile.h
> > index d48d46cc1b..74cea1a4a9 100644
> > --- a/packfile.h
> > +++ b/packfile.h
> > @@ -64,6 +64,11 @@ struct packfile_store {
> >  	 */
> >  	struct packed_git *packs;
> >
> > +	struct {
> > +		struct packed_git **packs;
> > +		unsigned flags;
> > +	} kept_cache;
> > +
> 
> This wouldn't be a bad time to add a comment here explaining what the
> kept_cache is for and what each of the struct's members represent. We
> can blame (at least one of) the author(s) of 20b031fede (packfile: add
> kept-pack cache for find_kept_pack_entry(), 2021-02-22) for omitting it
> in the first place ;-).

Good idea. I'll try to puzzle something together.

Patrick