From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 08 Sep 2025 06:42:04 GMT
Subject: Re: [PATCH RFC v2 1/7] meson: add infrastructure to build internal Rust library
Message-ID: <aL56vFa2SXlCDFWC@pks.im>
In-Reply-To: <l3apalzo6m5kydmfn6c376rswnfw5h34xpxauqarvxmlaksf6i@dhhdbat6gso3>

On Fri, Sep 05, 2025 at 12:47:20PM -0500, Justin Tobler wrote:
> On 25/09/05 01:50PM, Patrick Steinhardt wrote:
> > +# The 'rust' module was only introduced in Meson 1.0. Furthermore, the module
> > +# does not seem to work on macOS as expected right now. As such, we only
> > +# conditionally enable tests.
> > +if meson.version().version_compare('>=1.0.0') and host_machine.system() != 'darwin'
> > +  rustmod = import('rust')
> > +  rustmod.test('rust', libgit_rs)
> > +endif
> 
> Out of curiousity, what is the problem that we are seeing with macOS? I
> removed the darwin guard statement and didn't notice any problems when
> running `meson test rust`. Is this a well known problem with the Rust
> module?

It's this:

    Rust linker for the host machine: rustc -C linker=clang ld64 1053.12
    WARNING: Unknown keyword argument(s) in target rustxx: prelink, pic, rust_abi.
    src/meson.build:12:10: ERROR: Fatal warnings enabled, aborting

I haven't yet found a time to look into it more in depth, and assume
that it's fixed in more recent versions of Meson.

Patrick