From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 08 Sep 2025 06:41:43 GMT
Subject: Re: [PATCH RFC v2 2/7] Makefile: introduce infrastructure to build internal Rust library
Message-ID: <aL56pzCk0Qmb5gRN@pks.im>
In-Reply-To: <aL2kPUokmioiXCOG@szeder.dev>

On Sun, Sep 07, 2025 at 05:26:53PM +0200, SZEDER Gábor wrote:
> On Fri, Sep 05, 2025 at 01:50:58PM +0200, Patrick Steinhardt wrote:
> > diff --git a/Makefile b/Makefile
> > index 555b7f4dc3..e7b3c8e57b 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -2918,6 +2948,16 @@ scalar$X: scalar.o GIT-LDFLAGS $(GITLIBS)
> >  $(LIB_FILE): $(LIB_OBJS)
> >  	$(QUIET_AR)$(RM) $@ && $(AR) $(ARFLAGS) $@ $^
> >  
> > +$(RUST_LIB): FORCE
> 
> Why is this target FORCE-d instead of declaring its dependencies?

I was mostly doing that because cargo itself doesn't take any arguments,
so it's quite easy for the list to grow stale. Let me adapt it though to
take proper dependencies for now.

Patrick