From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 08 Sep 2025 06:40:36 GMT
Subject: Re: [PATCH RFC v2 7/7] ci: enable Rust for breaking-changes jobs
Message-ID: <aL56ZIxSTJFNemvH@pks.im>
In-Reply-To: <xmqq8qis399g.fsf@gitster.g>

On Fri, Sep 05, 2025 at 02:00:11PM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
> > index 3680446649..c718bd101a 100755
> > --- a/ci/run-build-and-tests.sh
> > +++ b/ci/run-build-and-tests.sh
> > @@ -9,7 +9,9 @@ case "$jobname" in
> >  fedora-breaking-changes-musl|linux-breaking-changes)
> >  	export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
> >  	export WITH_BREAKING_CHANGES=YesPlease
> > +	export WITH_RUST=YesPlease
> >  	MESONFLAGS="$MESONFLAGS -Dbreaking_changes=true"
> > +	MESONFLAGS="$MESONFLAGS -Drust=enabled"
> >  	;;
> >  linux-TEST-vars)
> >  	export OPENSSL_SHA1_UNSAFE=YesPlease
> 
> This had a slight interaction with other topics in flight that
> targets 3.0 boundary.  I believe the resolution I did was correct,
> but please double check for sanity.

Yup, the resolution looks good to me. Thanks!

Patrick