From: Taylor Blau <me@ttaylorr.com>
Date: Tue, 26 Aug 2025 01:41:13 GMT
Subject: Re: [PATCH v2 04/16] odb: move packfile map into `struct packfile_store`
Message-ID: <aK0QudxvIR4Jx7KK@nand.local>
In-Reply-To: <20250821-b4-pks-packfiles-store-v2-4-d10623355e9f@pks.im>

On Thu, Aug 21, 2025 at 09:39:02AM +0200, Patrick Steinhardt wrote:
> The object database tracks a map of packfiles by their respective paths,
> which is used to figure out whether a given packfile has already been
> loaded.With the introduction of the `struct packfile_store` we have a
> better place to host this list though.
>
> Move the map accordingly. `pack_map_entry_cmp()` isn't used anywhere but
> in "packfile.c" anymore after this change, so we convert it to a static
> function, as well.

This patch looks exactly as expected, let's keep reading...

Thanks,
Taylor