From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 04 Aug 2025 22:05:01 GMT
Subject: Re: [PATCH 5/9] commit-graph: stop using `the_hash_algo` via macros
Message-ID: <aJEujQnssKDNBWPW@nand.local>
In-Reply-To: <20250804-b4-pks-commit-graph-wo-the-repository-v1-5-850d626eb2e8@pks.im>

On Mon, Aug 04, 2025 at 10:17:21AM +0200, Patrick Steinhardt wrote:
> We have two macros `GRAPH_DATA_WIDTH` and `GRAPH_MIN_SIZE` that compute
> hash-dependent sizes. They do so by using the global `the_hash_algo`
> variable though, which we want to get rid of over time.
>
> Convert these macros into functions that accept the hash algorithm as
> input parameter. Adapt callers accordingly.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  commit-graph.c | 25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)

Very nice.

Thanks,
Taylor