From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 04 Aug 2025 07:38:21 GMT
Subject: Re: [PATCH v3 4/9] builtin/reflog: implement subcommand to write new entries
Message-ID: <aJBjbZqW-GuVkFzo@pks.im>
In-Reply-To: <87wm7nuvaz.fsf@iotcl.com>

On Fri, Aug 01, 2025 at 01:37:40PM +0200, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > +test_expect_success 'abbreviated object IDs' '
> > +	test_when_finished "rm -rf repo" &&
> > +	git init repo &&
> > +	(
> > +		cd repo &&
> > +		test_must_fail git reflog write refs/heads/something 12345 $ZERO_OID old-object-id 2>err &&
> 
> Is the object id rejected because it's short, or because there simply
> doesn't exist an object that starts with `12345`? You're not really
> testing the former, which you claim in the test name.

Good point, let me use an existing-but-abbreviated object instead.

Patrick