From: brian m. carlson Date: Tue, 22 Jul 2025 23:52:42 GMT Subject: Re: [PATCH 1/7] xdiff: introduce rust Message-ID: In-Reply-To: <20250722220233.7rdako7zjwyjqlmv@glandium.org> On 2025-07-22 at 22:02:33, Mike Hommey wrote: > On Thu, Jul 17, 2025 at 09:30:43PM +0000, brian m. carlson wrote: > > I would prefer that we not check in Cargo.lock in Git. Part of the > > reason is that it changes across versions and so building with a > > different version of the toolchain can update the file. > > That actually doesn't happen unless the file needs to be updated for > some reason, like Cargo.toml having new dependencies or `cargo update` > being run. I've actually seen several cases in my local Rust development where Cargo wants to update the file despite it not being necessary and `--locked` simply refusing to work without good cause. Perhaps those cases have been fixed, but it has happened in older versions. -- brian m. carlson (they/them) Toronto, Ontario, CA