From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Tue, 15 Jul 2025 21:48:05 GMT
Subject: Re: [PATCH v2 0/3] C99: declare bool experiment a success
Message-ID: <aHbMlUKNL2CAK_9I@fruit.crustytoothpaste.net>
In-Reply-To: <cover.1752587571.git.phillip.wood@dunelm.org.uk>

On 2025-07-15 at 13:52:49, Phillip Wood wrote:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
> 
> We've had a test balloon for C99's bool type since 8277dbe987
> (git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
> 2023-12-16). As it has been over 18 months since this was added and
> there have been no complaints let's declare it a success and convert
> the return type our other string predicates to match.
> 
> Thank you to everyone who commented on V1, the only change here is
> to fix the typos in the commit message for patch 2.

This series looked good to me.  I especially like the fact that we've
made it easier for me to figure out whether starts_with and friends are
booleans (that is, true if it starts with the value) or our standard
zero/negative-one (that is, false if it starts with the value).
-- 
brian m. carlson (they/them)
Toronto, Ontario, CA