From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 15 Jul 2025 10:50:12 GMT
Subject: Re: [PATCH 09/19] odb: introduce `odb_write_object()`
Message-ID: <aHYyZJnQqKCVdFwK@pks.im>
In-Reply-To: <878qkvdh4z.fsf@iotcl.com>

On Thu, Jul 10, 2025 at 08:39:56PM +0200, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/odb.h b/odb.h
> > index e922f256802..c96d2c29e9f 100644
> > --- a/odb.h
> > +++ b/odb.h
> > @@ -437,6 +437,44 @@ enum for_each_object_flags {
> >  	FOR_EACH_OBJECT_SKIP_ON_DISK_KEPT_PACKS = (1<<4),
> >  };
> >  
> > +enum {
> > +	/*
> > +	 * By default, `odb_write_object()` does not actually write anything
> > +	 * into the object store, but only computes the object ID. This flag
> > +	 * changes that so that the object will be written as a loose object
> > +	 * and persisted.
> > +	 */
> > +	WRITE_OBJECT_PERSIST = (1 << 0),
> > +
> > +	/*
> > +	 * Do not print an error in case something gose wrong.
> 
> While at it, shall we fix this typo?: s/gose/goes

Good eyes, will do.

Patrick