From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 08 Jul 2025 06:47:40 GMT
Subject: Re: [PATCH v3] ssh signing: don't detach the filename strbuf from key_file tempfile
Message-ID: <aGy_DEehFgw4A6va@pks.im>
In-Reply-To: <xmqq4ivn4t30.fsf@gitster.g>

On Mon, Jul 07, 2025 at 01:57:39PM -0700, Junio C Hamano wrote:
> redoste <redoste@redoste.xyz> writes:
> 
> > v2->v3:
> >  * merge the test with the previous ssh-agent test
> >  * export TMPDIR in a subshell to prevent the environment variable from
> >    leaking in the next tests
> >  * use test_must_be_empty instead of test_line_count
> 
> These sound all good.  Will queue.

Yup, the patch looks good to me. Thanks!

Patrick