From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 30 May 2025 08:00:52 GMT
Subject: Re: [GSoC PATCH 2/2] MyFirstContribution: add walken.c to meson.build
Message-ID: <aDlltNOH5pWBbwTQ@pks.im>
In-Reply-To: <20250529192036.75408-3-lucasseikioshiro@gmail.com>

On Thu, May 29, 2025 at 04:20:36PM -0300, Lucas Seiki Oshiro wrote:
> diff --git a/Documentation/MyFirstObjectWalk.adoc b/Documentation/MyFirstObjectWalk.adoc
> index 29d26abb47..3b66e48dd9 100644
> --- a/Documentation/MyFirstObjectWalk.adoc
> +++ b/Documentation/MyFirstObjectWalk.adoc
> @@ -96,12 +96,19 @@ maintaining alphabetical ordering:
>  { "walken", cmd_walken, RUN_SETUP },
>  ----
>  
> -Add it to the `Makefile` near the line for `builtin/worktree.o`:
> +Add an entry for the new command in the file of our two build systems (Make
> +and Meson) before the entry for `worktree`:
>  
> +- In the `Makefile`:
>  ----
>  BUILTIN_OBJS += builtin/walken.o
>  ----
>  
> +- In the `meson.build` file:
> +----
> +  'builtin/walken.c',
> +----

It's a bit hard for the reader to know _where_ to add this. How about we
say this instead:

    ----
    builtin_sources = [
      ...
     'builtin/walken.c',
      ...
    ]
    ----

That should make it was easier to figure out.

Patrick