From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 03 Jun 2025 13:51:28 GMT
Subject: Re: [PATCH v3 02/10] t/unit-tests: convert reftable basics test to use clar test framework
Message-ID: <aD794N8AjBqw0N43@pks.im>
In-Reply-To: <20250602122559.208780-3-kuforiji98@gmail.com>

On Mon, Jun 02, 2025 at 01:25:50PM +0100, Seyi Kuforiji wrote:
> Adapt reftable basics test file to clar by using clar assertions
> where necessary.Break up test edge case to improve modularity and

Nit: missing space.

> clarity.
> 
> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
> ---
>  Makefile                         |   2 +-
>  t/meson.build                    |   2 +-
>  t/unit-tests/t-reftable-basics.c | 219 -----------------------------
>  t/unit-tests/u-reftable-basics.c | 227 +++++++++++++++++++++++++++++++
>  4 files changed, 229 insertions(+), 221 deletions(-)
>  delete mode 100644 t/unit-tests/t-reftable-basics.c
>  create mode 100644 t/unit-tests/u-reftable-basics.c

Hm, these still show as deletion and addition :/ Did you try playing
around with the creation factor? What is the exact command that you have
used to generate these mails?

Patrick