From: Derrick Stolee Date: Wed, 26 Sep 2018 18:54:03 GMT Subject: Re: Git Test Coverage Report (Tuesday, Sept 25) Message-ID: In-Reply-To: <20180926184308.GA2253@hank.intra.tgummerer.com> On 9/26/2018 2:43 PM, Thomas Gummerer wrote: > On 09/26, Derrick Stolee wrote: >> This is a bit tricky to do, but I will investigate. For some things, the >> values can conflict with each other (GIT_TEST_SPLIT_INDEX doesn't play >> nicely with other index options, I think). > Just commenting on this point. I think all the index options should > be playing nicely with eachother. I occasionally run the test suite > with some of them turned on, and if something failed that was always > an actual bug. The different modes can be used in different > combinations in the wild as well, so we should get them to interact > nicely in the test suite. Thanks! I'm still working out details on this, since the test suite is broken with GIT_TEST_COMMIT_GRAPH due to a verbosity issue [1], which I forgot until I ran the tests with the variable on. I'll re-run with these variables: GIT_TEST_SPLIT_INDEX=1 GIT_TEST_FULL_IN_PACK_ARRAY=1 GIT_TEST_OE_SIZE=128 GIT_TEST_OE_DELTA_SIZE=128 GIT_TEST_VALIDATE_INDEX_CACHE_ENTRIES=1 GIT_TEST_FSMONITOR=$PWD/t/t7519/fsmonitor-all GIT_TEST_INDEX_VERSION=4 GIT_TEST_PRELOAD_INDEX=1 GIT_TEST_DISABLE_EOIE=1 GIT_TEST_INDEX_THREADS=1 Thanks, -Stolee [1] https://public-inbox.org/git/60aae3d6-35b2-94fb-afd7-6978e935a4f7@gmail.com/