From: Samuel GROOT Date: Tue, 14 Jun 2016 22:18:04 GMT Subject: Re: [PATCH v4 4/6] send-email: create email parser subroutine Message-ID: In-Reply-To: <20160613224753.GA4761@dcvr.yhbt.net> On 06/14/2016 12:47 AM, Eric Wong wrote: > Samuel GROOT wrote: >> On 06/09/2016 02:21 AM, Eric Wong wrote: >>> Samuel GROOT wrote: >>>> Email::Simple library uses qr/\x0a\x0d|\x0d\x0a|\x0a|\x0d/ [1]. >>>> Should we handle \n\r at end of line as well? >>> >>> "\n\r" can never happen with local $/ = "\n" >> >> If the email file contains "\n\r", setting $/ = "\n" will leave "\r" at >> the beginning of each line. >> >> We could trim them with: >> >> s/^\r//; >> s/\r?\n$//; >> >> But is it worth adding `s/^\r//;` to handle that extremely rare case? > > I doubt it. Having a "\r" in the wrong place is likely a bug in > whatever program that generated the email. It should be exposed > so whoever generated that email has a chance to fix it on their > end rather than being quietly hidden. s/\r?\n$// is fine then. Thanks.