From: Rubén Justo <rjusto@gmail.com>
Date: Wed, 07 Sep 2022 21:24:10 GMT
Subject: Re: [PATCH v2 1/2] branch: refactor "edit_description" code path
Message-ID: <a5e5f94d-965b-3766-60c2-27183148e052@gmail.com>
In-Reply-To: <xmqq7d2fszhk.fsf@gitster.g>


On 9/7/22 10:25 PM, Junio C Hamano wrote:

Maybe the return 1 when edit_branch_description(), was a typo I was maintaining?

>> -		}
>> -		strbuf_release(&branch_ref);
>> +		} else
>> +			ret = edit_branch_description(branch_name);
>>  
>> -		if (edit_branch_description(branch_name))
>> -			return 1;
>> +		strbuf_release(&branch_ref);
>> +		return ret;

Thanks for you review.