From: Jakub Narębski Date: Sat, 24 Sep 2016 21:22:21 GMT Subject: Re: [PATCH v8 02/11] pkt-line: extract set_packet_header() Message-ID: In-Reply-To: <20160920190247.82189-3-larsxschneider@gmail.com> W dniu 20.09.2016 o 21:02, larsxschneider@gmail.com pisze: > From: Lars Schneider > > Subject: [PATCH v8 02/11] pkt-line: extract set_packet_header() > > set_packet_header() converts an integer to a 4 byte hex string. Make > this function locally available so that other pkt-line functions can > use it. Ah. I have trouble understanding this commit message, as the set_packet_header() was not available before this patch, but it is good if one reads it together with commit summary / title. Writing Extracted set_packet_header() function converts... or New set_packet_header() function converts... would make it more clear, but it is all right as it is now. Perhaps also ... could use it. as currently no other pkt-line function but the one set_packet_header() was extracted from, namely format_packet(), uses it. But that is just nitpicking; no need to change on that account. > > Signed-off-by: Lars Schneider