From: Pat Thoyts Date: Thu, 25 Feb 2010 23:00:17 GMT Subject: Re: [PATCH] git-gui: fix "Explore Working Copy" for Windows again Message-ID: In-Reply-To: <20100225204451.GB12637@book.hvoigt.net> On 25 February 2010 20:44, Heiko Voigt wrote: > On Thu, Feb 25, 2010 at 01:14:22AM +0100, Markus Heidelberg wrote: >> It has already been fixed in commit 454efb47 (git-gui (Win): make >> "Explore Working Copy" more robust, 2009-04-01), but has been broken in >> commit 21985a11 (git-gui: handle non-standard worktree locations, >> 2010-01-23) by accidentally replacing too much with a new variable. >> >> The problem can be reproduced when starting git-gui from within a >> subdirectory. The solution is to convert the path name, explorer.exe is >> invoked with, to a platform native name. >> >> Signed-off-by: Markus Heidelberg >> --- > > I can confirm that this does fix the issue which is actually also > apparent on Windows XP. If no objections occur I would apply this to the > devel branch for msysgit. > > cheers Heiko Agreed - the loss of the [file nativename] around the path is the fault. Replacement with eval exec $explorer [list [file nativename $_gitworktree]] & will be sufficient for all platforms (the [list] protects any spaces in the path against the eval). Pat Thoyts