From: Derrick Stolee Date: Wed, 24 Oct 2018 13:22:47 GMT Subject: Re: [PATCH v3 09/12] commit-graph: convert to using the_hash_algo Message-ID: In-Reply-To: <20181022024342.489564-10-sandals@crustytoothpaste.net> On 10/21/2018 10:43 PM, brian m. carlson wrote: > Instead of using hard-coded constants for object sizes, use > the_hash_algo to look them up. In addition, use a function call to look > up the object ID version and produce the correct value. For now, we use > version 1, which means to use the default algorithm used in the rest of > the repository. This patch looks good to me. Later, we will want to delete the commit-graph file during the "upgrade the repo to newhash" process, but that can wait. Thanks, -Stolee