From: Johannes Schindelin Date: Thu, 07 May 2015 16:26:34 GMT Subject: Re: [PATCH v2 07/12] t4013: call git-merge instead of git-pull Message-ID: In-Reply-To: <1430988248-18285-8-git-send-email-pyokagan@gmail.com> Hi Paul, sorry for being so slow on reviewing your patches, but I saw that plenty of excellent feedback has made the second round of patches even better than the first one. I am particularly impressed by the thoroughness of the commit messages, they make reviewing much more pleasant. On 2015-05-07 10:44, Paul Tan wrote: > As such, replace the call to git-pull with a call to git-merge to reduce > the dependence on git-pull's functionality to reduce irrelevant test > breakage when git-pull is rewritten to C. Both this patch and 9/12 change `git pull` invocations to equivalent non-pull ones, but I wonder whether it would not be a better idea to leave them as-are, so that we can make sure that scripts out there that might use similar `git pull` invocations would be unaffected by the rewrite? Ciao, Dscho