From: Tian Yuchen <a3205153416@gmail.com>
Date: Mon, 23 Feb 2026 17:17:52 GMT
Subject: Re: [PATCH v10] setup: improve error diagnosis for invalid .git files
Message-ID: <a2b2e581-18ba-42ad-9bf1-a3e16b85f4e9@gmail.com>
In-Reply-To: <xmqq7bs3piz7.fsf@gitster.g>

Hi Junio,

 > But at some point, we may want to drop _ERR in those two new "these 
are not
 > errors" return values.

For the v11 I sent earlier, I kept `READ_GITFILE_ERR_MISSING` to 
maintain namespace consistency with the existing `READ_GITFILE_ERR_*` 
macros. However, I can't deny that decoupling these into neutral status 
codes (e.g., `READ_GITFILE_MISSING` vs actual fatal errors) also makes 
sense.

I'd be more than happy to drop the `_ERR` prefix in a v12 if you think 
it's better to address this cleanup right now, or we can definitely 
leave it for a future cleanup patch as you suggested.

Thanks,

Tian Yuchen