From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Thu, 09 Oct 2025 21:46:48 GMT
Subject: Re: [PATCH] [Outreachy] patch-ids: fix const correctness
Message-ID: <a299c0ea-8eeb-4a21-9924-ebd7c6f6e0bd@app.fastmail.com>
In-Reply-To: <20251009214445.1190274-1-okhuomonajayi54@gmail.com>

On Thu, Oct 9, 2025, at 23:44, Okhuomon Ajayi wrote:
> Fix const correctness warning in patch_id_neq() in patch-ids.c.
> ---
>  patch-ids.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/patch-ids.c b/patch-ids.c
> index a5683b462c..4a72c2cbe6 100644
> --- a/patch-ids.c
> +++ b/patch-ids.c
> @@ -42,7 +42,7 @@ static int patch_id_neq(const void *cmpfn_data,
>  			const void *keydata UNUSED)
>  {
>  	/* NEEDSWORK: const correctness? */
> -	struct diff_options *opt = (void *)cmpfn_data;
> +	const struct diff_options *opt = (void *)cmpfn_data;
>  	struct patch_id *a, *b;
> 
>  	a = container_of(eptr, struct patch_id, ent);
> -- 
> 2.43.0

Can’t the comment be removed now, though? If the cmit msg. says “Fix”.