From: Brandon Casey Date: Mon, 21 Jun 2010 17:37:15 GMT Subject: [PATCH 3/3] t/t7811-grep-open.sh: remove broken/redundant creation of fake "less" script Message-ID: <__CrpvAIIX9lgHHkBLHB9XDHAxBXxWdeEjxUzFD8IDsCriIMGC3nkCjyvNdGPppHV_Yf_CyEmg8@cipher.nrlssc.navy.mil> In-Reply-To: <__CrpvAIIX9lgHHkBLHB9fuuN7Rspzl7LFSDSwXwVCT6rYs_YOUHNMf7JZQbKaPHRl6AjsJ9dx8@cipher.nrlssc.navy.mil> From: Brandon Casey The fake "less" script was already created in a previous test titled 'setup: fake "less"', so it is redundant. Additionally, it is broken since the redirection of 'cat' is to a file named 'less', but the chmod operates on the file named by the $less variable which may not contain the value 'less'. So, just remove this code, and rely on the creation of the fake "less" script performed earlier within the test script. Signed-off-by: Brandon Casey --- t/t7811-grep-open.sh | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/t/t7811-grep-open.sh b/t/t7811-grep-open.sh index 2e5c701..c110441 100755 --- a/t/t7811-grep-open.sh +++ b/t/t7811-grep-open.sh @@ -109,11 +109,6 @@ test_expect_success 'git grep -O jumps to line in less' ' test_expect_success 'modified file' ' rm -f actual && - cat >less <<-\EOF && - #!/bin/sh - printf "%s\n" "$@" >actual - EOF - chmod +x $less && cat >expect <<-\EOF && +/*enum grep_pat_token grep.h -- 1.6.6.2