From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 18 Nov 2024 15:26:36 GMT
Subject: Re: [PATCH v2 0/7] reftable: stop using Git subsystems
Message-ID: <ZztcrOog-UtHx3us@pks.im>
In-Reply-To: <CAOLa=ZQxtQ9zBqN9U8ZnxaQ+uyMqQ1EnfEL9Br918y6CBxtvVQ@mail.gmail.com>

On Mon, Nov 18, 2024 at 02:30:44PM +0000, karthik nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Hi,
> >
> > this is the second version of my patch series that continues to detangle
> > the reftable library from the Git codebase.
> >
> > Changes compared to v1:
> >
> >   - Fix a commit message typo.
> >
> >   - Document the values of the newly introduced reftable format IDs.
> >
> >   - Include "reftable-basics.h" instead of "basics.h".
> >
> >   - Adapt `stack_fsync()` to take write options as input instead of the
> >     whole stack.
> >
> > Thanks!
> >
> 
> [snip]
> 
> I went through the patches and I think it looks great!

Thanks for your review!

Patrick