From: Taylor Blau Date: Wed, 20 Nov 2024 20:11:57 GMT Subject: Re: [PATCH v2 05/10] midx-write: pass down repository to `write_midx_file[_only]` Message-ID: In-Reply-To: <20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-5-e2f607174efc@gmail.com> On Tue, Nov 19, 2024 at 04:36:44PM +0100, Karthik Nayak wrote: > With this, all usage of global variables in `midx-write.c` is removed, > hence, remove the `USE_THE_REPOSITORY_VARIABLE` guard from the file. Very nicely done :-). Thanks for cleaning these up! Thanks, Taylor