From: Taylor Blau Date: Mon, 04 Nov 2024 21:01:34 GMT Subject: Re: [PATCH 10/11] pack-bitmap.c: record whether the result was filtered Message-ID: In-Reply-To: <20241011083545.GH18010@coredump.intra.peff.net> On Fri, Oct 11, 2024 at 04:35:45AM -0400, Jeff King wrote: > I wonder, though: should thin deltas just be turned off entirely when > filtering is in play? > > Likewise for --unpacked (though in practice I think it would never be > used with --thin, as it is about generating new on-disk packs). They should; that's what this commit is setting us up to do in the next one, which does not allocate the "convert to REF_DELTAs" bitmap when filtering is in play. Thanks, Taylor