From: Taylor Blau Date: Fri, 01 Nov 2024 14:36:54 GMT Subject: Re: [PATCH v4 0/9] packfile: avoid using the 'the_repository' global variable Message-ID: In-Reply-To: On Thu, Oct 31, 2024 at 04:05:56PM -0400, Taylor Blau wrote: > Hi Karthik, > > On Thu, Oct 31, 2024 at 10:39:43AM +0100, Karthik Nayak wrote: > > Range-diff against v3: > > Skimming the range-diff, this new version looks good to me. It would be > nice to hear from another reviewer or two before we start merging it > down, but I think that this is looking good to me. Hmmph. I spoke too soon, this new version appears to break CI on Windows, and thus broke the builds of 'jch' (and 'seen', by extension). https://github.com/ttaylorr/git/actions/runs/11602969593/job/32309061019 Can you have a look? In the meantime, I'm going to move this out of 'jch' to let CI run there again. Thanks, Taylor