From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 14 Oct 2024 22:00:35 GMT
Subject: Re: [PATCH 01/10] t/test-lib: fix quoting of TEST_RESULTS_SAN_FILE
Message-ID: <Zw2Ug71K3FhlC9m2@nand.local>
In-Reply-To: <601670912eeb80cc599c0e7af4ea87c370ae831d.1728906490.git.ps@pks.im>

On Mon, Oct 14, 2024 at 02:21:12PM +0200, Patrick Steinhardt wrote:
> Properly quote the value to fix the issue while using single-quotes to
> quote the inner value passed to eval. The issue can be reproduced by
> t0000 with such a path that contains spaces.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  t/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index b1a8ee5c002..241198ba95f 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1572,7 +1572,7 @@ then
>
>  	prepend_var LSAN_OPTIONS : dedup_token_length=9999
>  	prepend_var LSAN_OPTIONS : log_exe_name=1
> -	prepend_var LSAN_OPTIONS : log_path=\"$TEST_RESULTS_SAN_FILE\"
> +	prepend_var LSAN_OPTIONS : log_path="'$TEST_RESULTS_SAN_FILE'"

Makes sense.

Thanks,
Taylor