From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 14 Oct 2024 21:25:42 GMT
Subject: Re: Should object repacking only update server-info for packs instead of doing it for refs?
Message-ID: <Zw2MVqi0FLcMuR8Z@nand.local>
In-Reply-To: <569E3AEA-AC68-4186-B38C-2E47DAB9890E@gmail.com>

On Mon, Oct 14, 2024 at 09:33:17PM +0100, Luca Milanesio wrote:
> > It seems counterintuitive that an operation designed to repack
> > objects would be performing maintenance of any sort on refs?
>
> True, it should not touch info/refs IMHO, as you’re really not
> changing any refs.

Right. I don't think that the current behavior is a bug, but just that
it's doing unnecessary work from within 'git repack' to update the
info/refs file when it's known ahead of time that the refs haven't
changed.

I think it's reasonable to skip this step when repacking, but of course
we would still want to update info/packs (assuming that the repack
wasn't a noop, of course).

Thanks,
Taylor