From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 12 Sep 2024 10:05:02 GMT
Subject: Re: [PATCH 3/4] remote add: use strvec to store tracking branches
Message-ID: <ZuK8zjWyvMc77eQH@pks.im>
In-Reply-To: <f30c77bc36072df57662cac0cb7bf1bbea378062.1726067917.git.gitgitgadget@gmail.com>

On Wed, Sep 11, 2024 at 03:18:36PM +0000, Phillip Wood via GitGitGadget wrote:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
> 
> Store the list of branches to track in a ’struct strvec' instead of a
> 'struct string_list'. This in preparation for the next commit where it

s/in/is &/

> will be convenient to have them stored in a NULL terminated array. This
> means that we now duplicate the strings when storing them but the
> overhead is not significant.

Yup. Micro-optimizations like this typically don't really have any real
world effect anyway.

Patrick