From: Brandon Casey Date: Thu, 18 Sep 2008 15:48:54 GMT Subject: Re: [PATCH 4/4] diff.c: convert builtin funcname patterns to extended regular expressions Message-ID: In-Reply-To: <57518fd10809180353q2564d873k98e5f6d9041d0a7@mail.gmail.com> Jonathan del Strother wrote: > On Thu, Sep 18, 2008 at 1:21 AM, Brandon Casey wrote: >> Signed-off-by: Brandon Casey >> --- >> >> >> This is a blind conversion removing \\ before ( and { etc. >> and adding \\ before naked ( and { etc. >> >> I hope the authors who last touched these patterns will help with testing: > > > None of the patterns using \\s seem to work for me. I had to replace > them with [ \t] - is this a problem with the darwin regex > compatibility library or something? I applied the patches on master > (97d7fee2cb), and am running OS X 10.5.5. I was going to say possibly \s is a gnu extension, but if by "compatibility library", you mean compat/regex/regex.[ch] in the git source which is used by default now on OSX, then that _is_ the gnu library. I just tried the ruby pattern on IRIX6.5 and Solaris7 and \\s does not work. I am not using compat/regex/regex.[ch]. Same pattern works on linux. Looks like '\\s' needs to be changed to ' '. -brandon