From: Taylor Blau Date: Tue, 03 Sep 2024 21:24:38 GMT Subject: Re: [PATCH 2/4] hash.h: scaffolding for _fast hashing variants Message-ID: In-Reply-To: On Tue, Sep 03, 2024 at 01:47:09PM -0700, Junio C Hamano wrote: > > So I do not think that either of these two steps are necessary. > > I suspect that it is a wrong conclusion, as I meant (1) to be > prerequisite for doing (2) and (3), that gives us the real benefit > of being able to go faster than SHA1DC or even SHA-256. If (1) is > unnecessary (because it is already covered), that is great---we can > directly jump to (2) and (3). Ah, yes, after re-reading your message I am definitely mistaken here. I think that in the future doing this would be more than worthwhile. Thanks, Taylor