From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 10 Sep 2024 07:48:23 GMT
Subject: Re: [PATCH v2 2/3] chainlint: make error messages self-explanatory
Message-ID: <Zt_5xyDwG6YE1rFl@pks.im>
In-Reply-To: <20240910041013.68948-3-ericsunshine@charter.net>

On Tue, Sep 10, 2024 at 12:10:12AM -0400, Eric Sunshine wrote:
> diff --git a/t/chainlint/arithmetic-expansion.expect b/t/chainlint/arithmetic-expansion.expect
> index 338ecd5861..5677e16cad 100644
> --- a/t/chainlint/arithmetic-expansion.expect
> +++ b/t/chainlint/arithmetic-expansion.expect
> @@ -4,6 +4,6 @@
>  5 	baz
>  6 ) &&
>  7 (
> -8 	bar=$((42 + 1)) ?!AMP?!
> +8 	bar=$((42 + 1)) ?!LINT: missing '&&'?!
>  9 	baz
>  10 )

This looks a lot nicer than both the old state and the first iteration.
I certainly like it! I'm not really able to comment on the Perl code,
which mostly looks like gibberish to me (which isn't your fault). I'll
leave it to others to comment on that.

Patrick