From: Taylor Blau <me@ttaylorr.com>
Date: Thu, 29 Aug 2024 19:04:02 GMT
Subject: Re: [PATCH 0/8] pseudo-merge: avoid empty and non-closed pseudo-merge commits
Message-ID: <ZtDGImCRmC0N/cen@nand.local>
In-Reply-To: <20240817104412.GE551779@coredump.intra.peff.net>

On Sat, Aug 17, 2024 at 06:44:12AM -0400, Jeff King wrote:
> On Thu, Aug 15, 2024 at 01:30:56PM -0400, Taylor Blau wrote:
>
> > This series fixes a couple of small issues with pseudo-merge groups,
> > where it is possible to (a) select pseudo-merges that are not closed
> > over reachability with respect to the bitmap's pack or MIDX, and (b)
> > generate empty pseudo-merge commits.
>
> Thanks, the whole series looks good to me (I left some comments, but it
> is all just walking through my thought process).

Thanks (as always) for a thoughtful review!

Thanks,
Taylor