From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 07 Aug 2024 05:23:40 GMT
Subject: Re: [PATCH 4/6] t-reftable-stack: use reftable_ref_record_equal() to compare ref records
Message-ID: <ZrME3EXwf2qDfTew@tanuki>
In-Reply-To: <20240806142020.4615-5-chandrapratap3519@gmail.com>

On Tue, Aug 06, 2024 at 07:43:40PM +0530, Chandra Pratap wrote:
> diff --git a/t/unit-tests/t-reftable-stack.c b/t/unit-tests/t-reftable-stack.c
> index 14909b127e..0c15e654e8 100644
> --- a/t/unit-tests/t-reftable-stack.c
> +++ b/t/unit-tests/t-reftable-stack.c
> @@ -145,7 +145,7 @@ static void t_reftable_stack_add_one(void)
>  
>  	err = reftable_stack_read_ref(st, ref.refname, &dest);
>  	check(!err);
> -	check_str("master", dest.value.symref);
> +	check(reftable_ref_record_equal(&ref, &dest, GIT_SHA1_RAWSZ));
>  	check_int(st->readers_len, >, 0);

I think the change itself is sensible as long as we have tests that
verify that `reftable_ref_record_equal()` itself behaves as expected. I
don't think we have such tests anywhere though, uncovering a test gap.

Patrick