From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 05 Aug 2024 09:42:06 GMT
Subject: Re: [PATCH v3 6/6] [Newcomer] t7004-tag: description on the same line as test_expect_success
Message-ID: <ZrCebm52L16N2Agu@tanuki>
In-Reply-To: <20240804071137.30326-7-abdobngad@gmail.com>

On Sun, Aug 04, 2024 at 10:11:37AM +0300, AbdAlRahman Gad wrote:
> changed test_expect_success that are seperated from its name like:

We do not say "changed something to something", but rather use
imperative wording as if we were instructing the code itself to change.
So maybe something like the following:

    There are several tests in t7004 where the test description that
    follows `test_expect_success` is on a separate line, violating our
    coding style. Adapt these to be on the same line.

Patrick