From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 05 Aug 2024 09:36:48 GMT
Subject: Re: [PATCH v3 3/6] [Newcomer] t7004-tag: one command per line
Message-ID: <ZrCdME2Q7gT0KDrr@tanuki>
In-Reply-To: <20240804071137.30326-4-abdobngad@gmail.com>

On Sun, Aug 04, 2024 at 10:11:34AM +0300, AbdAlRahman Gad wrote:
> fix lines like these:
> 
> git tag -l >actual && test_cmp expect actual &&
> 
> to
> 
> git tag -l >actual &&
> test_cmp expect actual &&

Same remark here regarding the style of this commit message. I also
think that the message is both overly verbose and not telling enough at
the same point in time, because you require the reader to implicitly
derive what the change is that you are doing. Proposal:

    One of the tests in t7004 has multiple commands on a single line,
    which is discouraged. Adapt these by splitting up these into one
    line per command.

Patrick