From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 15 Aug 2024 05:13:07 GMT
Subject: Re: [PATCH v2 00/20] Stop using `the_repository` in "config.c"
Message-ID: <Zr2OXEwmySOc9gpL@tanuki>
In-Reply-To: <20240814192957.1518560-1-calvinwan@google.com>

On Wed, Aug 14, 2024 at 07:29:57PM +0000, Calvin Wan wrote:
> Hi Patrick,
> 
> Glad to see us slowly getting rid of the global, `the_repository`! I had
> missed your original series[1] introducing the
> USE_THE_REPOSITORY_AVAILABLE macro, but going thru it provided all the
> context necessary for this series.
> 
> I see there have been a few cleanups since the first version, and I
> didn't spot any typos on my end. Overall, this is a good step towards
> reducing our dependency on `the_repository` by removing it from the
> config subsystem. Additionally, this makes libifying that subsystem much
> easier since removing globals usage is a prerequisite for libification.
> I only left a non-blocking comment on one of the patches, but besides
> that this series LGTM. Feel free to cc me on any related series in the
> future!
> 
> [1] https://lore.kernel.org/git/cover.1718106284.git.ps@pks.im/

Thanks, will do!

Patrick