From: Patrick Steinhardt Date: Thu, 01 Aug 2024 08:20:01 GMT Subject: Re: [PATCH 07/23] builtin/submodule--helper: fix various trivial memory leaks Message-ID: In-Reply-To: <82f4bef1-57d9-4427-8316-5e63b573931d@gmail.com> On Wed, Jul 31, 2024 at 11:52:26PM +0200, Rubén Justo wrote: > On Fri, Jul 26, 2024 at 02:15:09PM +0200, Patrick Steinhardt wrote: > > > There are multiple trivial memory leaks in the submodule helper. Fix > > those. > > > > Signed-off-by: Patrick Steinhardt > > Hi Patrick, > > While working on another series, I fixed some leaks. But, I haven't > sent any patches. > > The series this message belongs to fixes all the leaks that my unsent > series addresses. So, I won't bother sending my patches. > > However, I think we can do better for the second leak solved in this > patch. I leave my patch at the end of this message in case you want > to take a look. Agreed, your patch looks way neater. I'll massage the patch a bit and then add it to the series with an "Original-patch-by" trailer. Patrick