From: Taylor Blau Date: Sun, 04 Aug 2024 16:10:57 GMT Subject: Re: [PATCH] log-tree: use decimal_width() Message-ID: In-Reply-To: <06783722-5184-41d5-8edd-94f97b2f2794@web.de> On Sat, Aug 03, 2024 at 02:33:24PM +0200, René Scharfe wrote: > --- > log-tree.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) This looks all very reasonable to me. Some history (if interesting): lineno_width(), which was the precursor to decimal_width() was introduced way back in cee7f245dc (git-pickaxe: blame rewritten., 2006-10-19). The piece this patch removes was added in e00de24b10 (format-patch -n: make sorting easier by padding number, 2007-02-09), but lineno_width() did not become part of pager.h until ec7ff5ba27 (make lineno_width() from blame reusable for others, 2012-02-12), hence why it wasn't already used here. Thanks, Taylor