From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 29 May 2024 09:19:53 GMT
Subject: Re: [GSoC][PATCH v5 0/2] t/: migrate helper/test-{sha1, sha256} to unit-tests/t-hash
Message-ID: <ZlbzOVgvSpUZOv8F@tanuki>
In-Reply-To: <20240529080030.64410-1-shyamthakkar001@gmail.com>

On Wed, May 29, 2024 at 01:30:28PM +0530, Ghanshyam Thakkar wrote:
> Changes in v5:
> - addressd Patrick's feedback about formatting
> - changed macros to be in do while loop instead of simple block,
>   according to Patrick's feedback
> 
> Ghanshyam Thakkar (2):
>   strbuf: introduce strbuf_addstrings() to repeatedly add a string
>   t/: migrate helper/test-{sha1, sha256} to unit-tests/t-hash

Thanks, this version looks good to me based on the range diff!

Patrick