From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 28 May 2024 05:14:08 GMT
Subject: Re: [PATCH v2 9/9] builtin/refs: new command to migrate ref storage formats
Message-ID: <ZlVoIBKdFI3F-l1W@tanuki>
In-Reply-To: <CAPig+cTV8eXHyFjG3gS+veQb_zUrdfz1zvNNE-aKMsaHoyG6hg@mail.gmail.com>

On Fri, May 24, 2024 at 03:29:06PM -0400, Eric Sunshine wrote:
> On Fri, May 24, 2024 at 2:24 PM Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
> > On 24/05/2024 11:15, Patrick Steinhardt wrote:
> > > +--dry-run::
> > > +     Perform the migration, but do not modify the repository. The migrated
> > > +     refs will be written into a separate directory that can be inspected
> > > +     separately. The name of the directory will be reported on stdout. This
> > > +     can be used to double check that the migration works as expected doing
> > > +     performing the actual migration.
> >
> > s/expected doing performing/expected before performing/ ?
> 
> The "doing performing" bit was noticed earlier[1]. I suppose in trying
> to fix it, Patrick accidentally removed "before" rather than removing
> either "doing" or "performing".
> 
> [1] https://lore.kernel.org/git/xmqqv833maxu.fsf@gitster.g/T/#m2c3eced90c6cd61bf3acda1acc354b4ab76011d3

Ugh, yeah, that's probably what happened. Thanks!

Patrick