From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 26 Apr 2024 11:43:12 GMT
Subject: Re: [PATCH v3 1/3] completion: add 'symbolic-ref'
Message-ID: <ZiuTUFtZxBBehVVs@tanuki>
In-Reply-To: <20240425101845.708554-1-rhi@pengutronix.de>

On Thu, Apr 25, 2024 at 12:18:42PM +0200, Roland Hieber wrote:
> Even 'symbolic-ref' is only completed when
> GIT_COMPLETION_SHOW_ALL_COMMANDS=1 is set, it currently defaults to
> completing file names, which is not very helpful. Add a simple
> completion function which completes options and refs.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>

Thanks, this version looks good to me.

Patrick