From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 10 Apr 2024 09:42:47 GMT
Subject: Re: [PATCH v2 1/8] fast-import: tighten path unquoting
Message-ID: <ZhZfF5YH-uwx-wYb@tanuki>
In-Reply-To: <6C467327-0DB1-4E1F-8CB5-23DE45271348@archibald.dev>

On Wed, Apr 10, 2024 at 09:14:16AM +0000, Thalia Archibald wrote:
> On Apr 10, 2024, at 01:51, Chris Torek <chris.torek@gmail.com> wrote:
> > On Wed, Apr 10, 2024 at 1:47 AM Thalia Archibald <thalia@archibald.dev> wrote:
> >> strchrnul does what I want here and I’ve replaced it with that.
> > 
> > `strchrnul` is a GNU extension (found on a lot of systems, but not
> > part of C90 or C99).
> 
> I can’t speak to Git standards, but it seems broadly used in Git, including
> three times already in fast-import:

It's fine to use `strchrnul()` in Git. In case libc doesn't provide it
we have a fallback implementation in "git-compat-util.h".

Patrick