From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Wed, 27 Mar 2024 21:34:30 GMT
Subject: Re: [PATCH 12/13] strvec: implement swapping two strvecs
Message-ID: <ZgSQ5o_KyqDaxz1m@tapette.crustytoothpaste.net>
In-Reply-To: <xmqqbk6z1iba.fsf@gitster.g>

On 2024-03-27 at 21:22:17, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> 
> >> +
> >> +void strvec_swap(struct strvec *a, struct strvec *b)
> >> +{
> >> +	struct strvec t = *a;
> >> +	*a = *b;
> >> +	*b = t;
> >> +}
> >
> > Isn't this equivalent to `SWAP(*a, *b)`?
> 
> Yes.  "make coccicheck" does flag this one.
> 
> Let's drop this step, and tweak the 13/13 patch to make its sole
> caller directly use SWAP() instead, perhaps like so:

Great, I'll include that in a reroll, likely this weekend.
-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA