From: Josh Steadmon <steadmon@google.com>
Date: Tue, 12 Mar 2024 21:44:15 GMT
Subject: Re: [PATCH v2 6/6] parse-options: rearrange long_name matching code
Message-ID: <ZfDMr8rRftxXmTXf@google.com>
In-Reply-To: <20240303121944.20627-7-l.s.r@web.de>

On 2024.03.03 13:19, René Scharfe wrote:
> Move the code for handling a full match of long_name first and get rid
> of negations.  Reduce the indent of the code for matching abbreviations
> and remove unnecessary curly braces.  Combine the checks for whether
> negation is allowed and whether arg is "n", "no" or "no-" because they
> belong together and avoid a continue statement.  The result is shorter,
> more readable code.
> 
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  parse-options.c | 37 +++++++++++++++----------------------
>  1 file changed, 15 insertions(+), 22 deletions(-)

This version is much more readable, thanks for the cleanup!