From: Patrick Steinhardt <ps@pks.im>
Date: Thu, 07 Dec 2023 08:57:55 GMT
Subject: Re: [PATCH 3/9] imap-send: don't use git_die_config() inside callback
Message-ID: <ZXGJE-pkb3BjlO-d@tanuki>
In-Reply-To: <20231207072458.GC1277973@coredump.intra.peff.net>

On Thu, Dec 07, 2023 at 02:24:58AM -0500, Jeff King wrote:
[snip]
> diff --git a/imap-send.c b/imap-send.c
> index 996651e4f8..5b0fe4f95a 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1346,7 +1346,7 @@ static int git_imap_config(const char *var, const char *val,
>  		server.port = git_config_int(var, val, ctx->kvi);
>  	else if (!strcmp("imap.host", var)) {
>  		if (!val) {
> -			git_die_config("imap.host", "Missing value for 'imap.host'");
> +			return error("Missing value for 'imap.host'");

Nit: while at it we might also mark this error for translation. Not
worth a reroll on its own though.

Patrick