From: Oswald Buddenhagen Date: Fri, 27 Oct 2023 15:53:34 GMT Subject: Re: [PATCH v2 5/5] ci: add support for GitLab CI Message-ID: In-Reply-To: On Fri, Oct 27, 2023 at 02:17:02PM +0100, Phillip Wood wrote: >On 27/10/2023 12:01, Oswald Buddenhagen wrote: >> On Fri, Oct 27, 2023 at 11:25:41AM +0200, Patrick Steinhardt wrote: >>> +    export GIT_PROVE_OPTS="--timer --jobs $(nproc)" >>> +    export GIT_TEST_OPTS="--verbose-log -x" >>> >> fwiw (as this is again only copied), export with assignment is a >> bash-ism > >Not according to >https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#export > hmm, it's there since at least SUSv1, aka XPG4v2, in 1994. i didn't bother digging deeper. >It is true that in our test suite we separate a variable assignment >when exporting. Presumably that is because someone reported that their >shell did not support the "export name=WORD" syntax in the past. > most likely it's just a historical default, not the result of a specific bug report. the assumption that it's bash-specific is wide-spread. >As we're already using this syntax with the same docker images in >Github Actions I think we can assume it is safe here. > i guess so. docker seems a tad unlikely to run some ancient bourne shells ... regards