From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 27 Oct 2023 08:17:28 GMT
Subject: Re: [PATCH 3/5] ci: group installation of Docker dependencies
Message-ID: <ZTtyGBLvH8Fji-C-@tanuki>
In-Reply-To: <ZTokgo1mQ7ZVH7GU@ugly>

On Thu, Oct 26, 2023 at 10:34:10AM +0200, Oswald Buddenhagen wrote:
> On Thu, Oct 26, 2023 at 10:00:12AM +0200, Patrick Steinhardt wrote:
> > Pull in "lib.sh" into "install-docker-dependencies.sh" such that we can
> > set up proper groups for those dependencise. This allows the reader to
> 					  ^^ !!!
> > collapse sections in the CI output on GitHub Actions (and later on on
> > GitLab CI).
> > 
> the structure of the text is kind of backwards - the fact that you need to
> pull in a lib is just a consequence, not the intent, which imo should come
> first. tough it mostly doesn't matter, as it's just one short paragraph.
> 
> regards

Good point indeed. Will rewrite.

Patrick