From: Taylor Blau <me@ttaylorr.com>
Date: Mon, 30 Oct 2023 18:10:38 GMT
Subject: Re: [PATCH v2 03/12] builtin/show-ref: fix leaking string buffer
Message-ID: <ZT/xnsoAs5cK+bsU@nand.local>
In-Reply-To: <bb0d656a0b40b79c90dc2505239976a93f18f432.1698314128.git.ps@pks.im>

On Thu, Oct 26, 2023 at 11:56:29AM +0200, Patrick Steinhardt wrote:
> Fix a leaking string buffer in `git show-ref --exclude-existing`. While
> the buffer is technically not leaking because its variable is declared
> as static, there is no inherent reason why it should be.

Well spotted and fixed. I ran the test suite in GIT_TEST_PASSING_SANITIZE_LEAK's
"check" mode and didn't find anything that was made leak-free by this
patch not already marked as such. So this (and the rest of the series up
to this point) LGTM.

Thanks,
Taylor